Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the appropriate handlers are used for tags management #531

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Ensure the appropriate handlers are used for tags management #531

merged 4 commits into from
Oct 15, 2021

Conversation

alinabuzachis
Copy link
Collaborator

@alinabuzachis alinabuzachis commented Oct 8, 2021 •
edited
Loading

SUMMARY

Ensure the appropriate handlers are used for tags management

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_nat_gateway
ec2_vpc_igw
ec2_vpc_dhcp_option
ec2_vpc_endpoint

@alinabuzachis
Ensure the appropriate hanglers are used for tags management
3bee05c 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis alinabuzachis changed the title Ensure the appropriate hanglers are used for tags management Ensure the appropriate handlers are used for tags management Oct 8, 2021
@alinabuzachis
Add changelog fragment
f1ac41b 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@ansibullbot
Copy link

cc @Etherdaemon @jillr @joelthompson @jonhadfield @linuxdynasty @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Oct 8, 2021
tremble
tremble requested changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM, just the unused import

plugins/modules/ec2_vpc_nat_gateway.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_dhcp_option.py Show resolved Hide resolved
@tremble
Copy link
Contributor

tremble commented Oct 8, 2021

Unit test failures: https://dashboard.zuul.ansible.com/t/ansible/build/dd11484ca61641aab6ea8b1d12088e30

Looks like ec2_vpc_dhcp_option has some unit tests. I'd be inclined to delete the broken ones since we have integration tests

@tremble tremble added the gate label Oct 14, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alinabuzachis
Copy link
Collaborator Author

recheck

@alinabuzachis
Copy link
Collaborator Author

recheck

1 similar comment
@tremble
Copy link
Contributor

tremble commented Oct 15, 2021

recheck

@tremble tremble added gate and removed gate labels Oct 15, 2021
@ansible-zuul ansible-zuul bot merged commit 67839a3 into ansible-collections:main Oct 15, 2021
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@ansible-zuul
Merge pull request ansible-collections#531 from tremble/rds_instance/…
06aeebb 
…parallel-tests

Run rds_instance tests in parallel (Databases are *slow*)

Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_maintainer plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alinabuzachis @ansibullbot @tremble